Skip to content

[swift-api-digester] Update for 'deinit' as a special name. #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2017
Merged

[swift-api-digester] Update for 'deinit' as a special name. #11288

merged 1 commit into from
Aug 1, 2017

Conversation

@jrose-apple
Copy link
Contributor

Missed switch case from the #10965 series. Unbreaks the build after -Werror=switch.

@jrose-apple jrose-apple requested a review from ahoppen August 1, 2017 16:53
@jrose-apple
Copy link
Contributor Author

cc @atrick

@swift-ci Please smoke test and merge

ahoppen
ahoppen approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much exactly the changes I just submitted as #11287.
Sorry, I didn't see the warning while running tests and don't usually build all targets. My fault.

@CodaFi CodaFi mentioned this pull request Aug 1, 2017
Merged
@jrose-apple jrose-apple mentioned this pull request Aug 1, 2017
Merged
@moiseev
Copy link
Contributor

moiseev commented Aug 1, 2017 

/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/tools/swift-api-digester/swift-api-digester.cpp:1099:28: error: no member named 'Deinit' in 'swift::DeclBaseName::Kind'
  case DeclBaseName::Kind::Deinit:
       ~~~~~~~~~~~~~~~~~~~~^
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/tools/swift-api-digester/swift-api-digester.cpp:1096:16: error: enumeration value 'Destructor' not handled in switch [-Werror,-Wswitch]
  switch (name.getKind()) {
               ^
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/tools/swift-api-digester/swift-api-digester.cpp:1096:16: note: add missing switch cases
  switch (name.getKind()) {
               ^
2 errors generated.

@jrose-apple
Copy link
Contributor Author

Shoot. Alex can spell and I can't.

@jrose-apple
[swift-api-digester] Update for 'deinit' as a special name.
3e72cf9 
Missed switch case from the 17ddc58 series. Unbreaks the build
after -Werror=switch.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

1 similar comment
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@atrick
Copy link
Contributor

atrick commented Aug 1, 2017

Merging without Linux, because I can.

@atrick atrick merged commit 7d7e496 into swiftlang:master Aug 1, 2017
@jrose-apple jrose-apple deleted the deinit-Wswitch branch August 1, 2017 18:28
@jrose-apple
Copy link
Contributor Author

Thanks, Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrose-apple @moiseev @atrick @ahoppen